Code Review 1 #161

New issue

Closed

opened 2025-12-02 15:54:55 +01:00 by elena · 1 comment

elena commented

2025-12-02 15:54:55 +01:00

(Migrated from git.sopranium.de)

No description provided.

yide commented

2025-12-02 19:57:18 +01:00

(Migrated from git.sopranium.de)

1.Optimized the entity check. Instead of creating a new list every time, we now reuse the same one. This stops the Garbage Collector from causing lag spikes.
2.Moved sled spawning from World.cs to WorldBuilder.cs to fix a bug where loading a save would duplicate the sled.
3.Fixed a bug where loading a save file would trigger loot drops for all existing entities (e.g., trees dropping wood). I implemented a new Unload() method in the Entity class to silently remove entities without triggering the OnDestroyed event, which LootBehavior listens to.
4.resolve some warning

1.Optimized the entity check. Instead of creating a new list every time, we now reuse the same one. This stops the Garbage Collector from causing lag spikes. 2.Moved sled spawning from World.cs to WorldBuilder.cs to fix a bug where loading a save would duplicate the sled. 3.Fixed a bug where loading a save file would trigger loot drops for all existing entities (e.g., trees dropping wood). I implemented a new Unload() method in the Entity class to silently remove entities without triggering the OnDestroyed event, which LootBehavior listens to. 4.resolve some warning

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ufr/sopra10#161

No description provided.

Rows
Columns